Skip to content

REFACTOR: put all the standard library in std.nu#8489

Merged
fdncred merged 3 commits intonushell:mainfrom
amtoine:refactor/bring-the-standard-library-together-in-std-nu
Mar 17, 2023
Merged

REFACTOR: put all the standard library in std.nu#8489
fdncred merged 3 commits intonushell:mainfrom
amtoine:refactor/bring-the-standard-library-together-in-std-nu

Conversation

@amtoine
Copy link
Copy Markdown
Member

@amtoine amtoine commented Mar 16, 2023

Warning
this PR is the result of a demand from the core team, to have the simplest structure for the standard library, at least for now 👍

Description

this PR mainly

  • moved the dirs.nu module to the end of std.nu
  • fixed the imports in test_dirs.nu

User-Facing Changes

$nothing

Tests + Formatting

with the new runner from #8443, we get as expected 👌

>_ nu crates/nu-utils/standard_library/tests.nu
INFO  Run tests in test_dirs
DEBUG Run test test_dirs/test_dirs_command
INFO  Run tests in test_std
DEBUG Run test test_std/test_assert
DEBUG Run test test_std/test_match
DEBUG Run test test_std/test_path_add

After Submitting

$nothing

amtoine added 3 commits March 16, 2023 19:24
@amtoine
move the dirs.nu module to std.nu
6b43984 
To reproduce:
```nushell
sd 'export def-env "(.*)" \[' 'export def-env "dirs $1" [' crates/nu-utils/standard_library/dirs.nu
"\n" | save --append crates/nu-utils/standard_library/std.nu
open crates/nu-utils/standard_library/dirs.nu --raw | save --append crates/nu-utils/standard_library/std.nu
rm crates/nu-utils/standard_library/dirs.nu
```
@amtoine
remove the "import" section of std.nu
e42a03c
@amtoine
fix the tests in test_dirs.nu
6189105
@fdncred
Copy link
Copy Markdown
Contributor

fdncred commented Mar 16, 2023

Thanks. Let me know when you're ready to land this.

@presidento presidento mentioned this pull request Mar 16, 2023
Merged
@sholderbach sholderbach added the A:std-library Defining and improving the standard library written in Nu label Mar 17, 2023
@amtoine
Copy link
Copy Markdown
Member Author

amtoine commented Mar 17, 2023

@fdncred

Thanks. Let me know when you're ready to land this.

i think so 👍

@fdncred fdncred merged commit bb8949f into nushell:main Mar 17, 2023
@fdncred
Copy link
Copy Markdown
Contributor

fdncred commented Mar 17, 2023

Thanks

@amtoine amtoine deleted the refactor/bring-the-standard-library-together-in-std-nu branch March 17, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A:std-library Defining and improving the standard library written in Nu

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amtoine @fdncred @sholderbach