Add -i flag back to get and select#8488
Merged
rgwood merged 3 commits intonushell:mainfrom Mar 16, 2023
Merged
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8488 +/- ##
==========================================
- Coverage 68.07% 68.06% -0.01%
==========================================
Files 621 621
Lines 100010 99958 -52
==========================================
- Hits 68081 68036 -45
+ Misses 31929 31922 -7
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8379 removed the
-iflag fromgetandselectbecause the new?functionality covers most of the same use cases. However, #8480 made me realize that-iis still useful when dealing with cell paths in variables.This PR re-adds the
-iflag togetandselect. It works by just marking every member in the cell path as optional, which will behave slightly differently than-iused to (previously it would suppress any errors, even type errors) but IMO that's OK.