make better usage of error value in catch block#8460
Merged
rgwood merged 6 commits intonushell:mainfrom Mar 16, 2023
Merged
Conversation
catch block
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8460 +/- ##
==========================================
- Coverage 68.13% 68.12% -0.01%
==========================================
Files 620 620
Lines 99723 99733 +10
==========================================
- Hits 67950 67947 -3
- Misses 31773 31786 +13
|
rgwood
approved these changes
Mar 16, 2023
Contributor
rgwood
left a comment
There was a problem hiding this comment.
Cool! This looks great from a user-facing perspective.
Converting errors into records feels a little hacky; it would be nice if we were able to pass around errors as data. But I think that would be a lot of work, this approach seems like a practical step forward for now.
Contributor
Author
Sadly I've tried it, but it breaks many things. Currently when nushell meets |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #8402 #8391
The cause of these issue if when we want to evaluate a expression with
Value::Error, nushell show error immediately. To fix the issue, we can wrap theValue::Errorinto aValue::Record. So user can see the message he want.User-Facing Changes
Before
After
As we can see, error becomes a record with
msg,debug,rawcolumns.Value::Errorinformation as a string.Value::Erroritself, if user want to re-raise the error, just use$e | get rawTests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspaceto check that all tests passAfter Submitting
If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.