Remove get -i from default env file#8390
Merged
sholderbach merged 1 commit intonushell:mainfrom Mar 10, 2023
Merged
Conversation
Contributor
Author
|
I did some manual testing on Windows and Linux, both seem good. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8390 +/- ##
==========================================
- Coverage 68.48% 68.12% -0.37%
==========================================
Files 620 620
Lines 99495 99495
==========================================
- Hits 68140 67779 -361
- Misses 31355 31716 +361 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up from #8173, which was merged shortly after the 0.76 release. That PR changed
default_env.nuso that the user's home folder is displayed as~in the left prompt. It did so usingget -i.This PR just rewrites the Nu code from #8173 to use
try/catchinstead of-i, which will make it easier to remove the-iflags fromgetandselecteventually (see #8379).I would like to merge this before the 0.77 release, so we don't end up with lots of
env.nufiles usingget -iout in the wild.