show more informaiton when there are toml errors#8140
Merged
fdncred merged 1 commit intonushell:mainfrom Feb 20, 2023
fdncred:more_specific_toml_errors
Merged
show more informaiton when there are toml errors#8140fdncred merged 1 commit intonushell:mainfrom fdncred:more_specific_toml_errors
fdncred merged 1 commit intonushell:mainfrom
fdncred:more_specific_toml_errors
Conversation
Member
|
Much nicer! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While debugging #8139 I noticed that there was some error information coming from the toml crate that we were not displaying. This would've helped me to understand what was going on. So, this PR shows more verbose errors when toml fails to parse.
Before
After
User-Facing Changes
(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)
Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspaceto check that all tests passAfter Submitting
If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.