fixes a def parsing bug with a default list#8096
Merged
fdncred merged 1 commit intonushell:mainfrom Feb 22, 2023
fdncred:fix_def_list_parsing_bug
Merged
fixes a def parsing bug with a default list#8096fdncred merged 1 commit intonushell:mainfrom fdncred:fix_def_list_parsing_bug
fdncred merged 1 commit intonushell:mainfrom
fdncred:fix_def_list_parsing_bug
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8096 +/- ##
==========================================
+ Coverage 53.07% 54.17% +1.09%
==========================================
Files 606 608 +2
Lines 98249 99088 +839
==========================================
+ Hits 52146 53679 +1533
+ Misses 46103 45409 -694
|
Contributor
Author
|
I was thinking about this and another way to fix this problem is to allow specific list types to be defined on parameters for custom commands. Such as: I'm just not sure where to make that change. Seems like some additional parsing may be required somewhere. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug where a default list in a custom command parameter wasn't being accepted. The reason was because it was comparing specific types of list like
list<any>!=list<string>. So, this PR attempts to fix that.Before
After
closes #8092
User-Facing Changes
Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspaceto check that all tests passAfter Submitting
If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.