Skip to content

fix rename when it is passed an empty column list to rename#8086

Merged
fdncred merged 2 commits intonushell:mainfrom
fdncred:fix_rename_with_empty_list
Feb 15, 2023
Merged

fix rename when it is passed an empty column list to rename#8086
fdncred merged 2 commits intonushell:mainfrom
fdncred:fix_rename_with_empty_list

Conversation

@fdncred
Copy link
Copy Markdown
Contributor

@fdncred fdncred commented Feb 15, 2023

Description

This PR fixes a bug that occurs if you pass rename --column and empty list like ls | rename -c [].

Before

> ls | rename -c []
thread 'main' panicked at 'index out of bounds: the len is 0 but the index is 0', crates\nu-command\src\filters\rename.rs:110:15
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

After

> ls | rename -c []
Error: nu::shell::type_mismatch (link)

  × Type mismatch.
   ╭─[entry #1:1:1]
 1 │ ls | rename -c []
   ·                ─┬
   ·                 ╰── The list cannot be empty and must contain only two values: the column's name and its replacement value
   ╰────

User-Facing Changes

(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace to check that all tests pass

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

@fdncred fdncred added this pull request to the merge queue Feb 15, 2023
Merged via the queue into nushell:main with commit cba3e10 Feb 15, 2023
@fdncred fdncred deleted the fix_rename_with_empty_list branch February 15, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant