Disable auto-benchmark harness for crates#8057
Merged
sholderbach merged 1 commit intonushell:mainfrom Feb 12, 2023
Merged
Conversation
This disables automatic detection of `#[bench]` and other benchmarks within the crates. Our benchmarks should all live in `benches` This fixes a problem with criterion flags and should also reduce the build requirements for `cargo bench` a bit Taken from nushell#7952 See: https://bheisler.github.io/criterion.rs/book/faq.html#cargo-bench-gives-unrecognized-option-errors-for-valid-command-line-options
3 tasks
Codecov ReportBase: 55.24% // Head: 55.23% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #8057 +/- ##
==========================================
- Coverage 55.24% 55.23% -0.01%
==========================================
Files 606 606
Lines 99060 99060
==========================================
- Hits 54722 54720 -2
- Misses 44338 44340 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This disables automatic detection of
#[bench]and other benchmarkswithin the crates. Our benchmarks should all live in
benchesThis fixes a problem with criterion flags and should also reduce the
build requirements for
cargo bencha bitTaken from #7952
See: https://bheisler.github.io/criterion.rs/book/faq.html#cargo-bench-gives-unrecognized-option-errors-for-valid-command-line-options
User-Facing Changes
None