#8027 Hide implementation details in invalid cd call#8049
Merged
rgwood merged 2 commits intonushell:mainfrom Feb 13, 2023
Merged
#8027 Hide implementation details in invalid cd call#8049rgwood merged 2 commits intonushell:mainfrom
rgwood merged 2 commits intonushell:mainfrom
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8049 +/- ##
=======================================
Coverage 55.23% 55.23%
=======================================
Files 606 606
Lines 99065 99065
=======================================
+ Hits 54720 54723 +3
+ Misses 44345 44342 -3
|
…include implemntation details nushell#8027
848d42c to
d4bf80e
Compare
rgwood
approved these changes
Feb 13, 2023
Contributor
rgwood
left a comment
There was a problem hiding this comment.
Thanks for the first PR!
I've tweaked it a tiny bit; I don't think we need the help: IO Error ... line at all.
Contributor
Author
|
I was thinking the same, but didn’t want to be too presumptuous hahaha. Thank you! I look forward to being more of a part of this project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
GH issue
The current error message for a cd command includes a Debug output of the
io::Errorbeing returned fromcanonicalize_with, so it's been replaced with a more user friendly and readable depiction of the error.User-Facing Changes
As described in the issue, I've changed the error message for a cd into a directory that does not exist from:
To:
Tests + Formatting
Don't forget to add tests that cover your changes.
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspaceto check that all tests passAfter Submitting
If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.