Skip to content

spanned error on path exists command#7717

Merged
fdncred merged 1 commit intonushell:mainfrom
WindSoilder:path_err_spanned
Jan 12, 2023
Merged

spanned error on path exists command#7717
fdncred merged 1 commit intonushell:mainfrom
WindSoilder:path_err_spanned

Conversation

@WindSoilder
Copy link
Copy Markdown
Contributor

Description

Closes: #7696

User-Facing Changes

Before:

❯ 'temp/aa' | path exists
Error: nu::shell::io_error (link)

  × I/O error
  help: Os { code: 13, kind: PermissionDenied, message: "Permission denied" }

After:

❯ 'temp/aa' | path exists
Error: nu::shell::io_error (link)

  × I/O error
   ╭─[entry #42:1:1]
 1 │ 'temp/aa' | path exists
   · ────┬────
   ·     ╰── Permission denied (os error 13)
   ╰────

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace to check that all tests pass

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

@fdncred fdncred merged commit 48b7b41 into nushell:main Jan 12, 2023
@fdncred
Copy link
Copy Markdown
Contributor

fdncred commented Jan 12, 2023

Thanks @WindSoilder !!

@WindSoilder WindSoilder deleted the path_err_spanned branch August 2, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bad error message in path exists?

3 participants