Skip to content

ensure error in else is forwarded appropriately#7411

Merged
kubouch merged 2 commits intonushell:mainfrom
merelymyself:add_quotes_to_hash_file_autocomplete
Dec 9, 2022
Merged

ensure error in else is forwarded appropriately#7411
kubouch merged 2 commits intonushell:mainfrom
merelymyself:add_quotes_to_hash_file_autocomplete

Conversation

@merelymyself
Copy link
Copy Markdown
Contributor

Description

Fixes #7407.

/home/gabriel/CodingProjects/nushell〉if false { 'a' } else { $foo }    12/09/2022 08:14:48 PM
Error: nu::parser::variable_not_found (link)

  × Variable not found.
   ╭─[entry #1:1:1]
 1 │ if false { 'a' } else { $foo }
   ·                         ──┬─
   ·                           ╰── variable not found
   ╰────

User-Facing Changes

(List of all changes that impact the user experience here. This helps us keep track of breaking changes.)

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace to check that all tests pass

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

Copy link
Copy Markdown
Member

@sholderbach sholderbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am no parser internals expert, but this looks good to me. Errors remain errors and the tests covers the motivating issue.

@kubouch
Copy link
Copy Markdown
Contributor

kubouch commented Dec 9, 2022

Perfect, thanks!

@kubouch kubouch merged commit fc5fe4b into nushell:main Dec 9, 2022
@rgwood
Copy link
Copy Markdown
Contributor

rgwood commented Dec 9, 2022

Nice one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading error message if there is error inside else branch

4 participants