Skip to content

Change all --insensitive flags to --ignore-case#7198

Merged
fdncred merged 1 commit intonushell:mainfrom
webbedspace:insensitive
Nov 22, 2022
Merged

Change all --insensitive flags to --ignore-case#7198
fdncred merged 1 commit intonushell:mainfrom
webbedspace:insensitive

Conversation

@webbedspace
Copy link
Copy Markdown
Contributor

Description

Support for this breaking change was raised in #7191. This affects sort, sort-by, str contains and find. --ignore-case is used by a few POSIX programs such as less and grep, as well as a few other popular utils like tree and wget. Since long names aren't especially popular (existing primarily for self-documentation purposes), I consider this on the shallow end of the compat-break scale.

Note that the -i short flag is not affected.

User-Facing Changes

See above.

Tests + Formatting

Don't forget to add tests that cover your changes.

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace --features=extra to check that all tests pass

After Submitting

If your PR had any user-facing changes, update the documentation after the PR is merged, if necessary. This will help us keep the docs up to date.

@fdncred
Copy link
Copy Markdown
Contributor

fdncred commented Nov 22, 2022

Thanks

@fdncred fdncred merged commit bb0b087 into nushell:main Nov 22, 2022
@rgwood rgwood added the notes:breaking-changes This PR implies a change affecting users and has to be noted in the release notes label Nov 23, 2022
@rgwood
Copy link
Copy Markdown
Contributor

rgwood commented Nov 23, 2022

Thank you! If you have time can you please document this breaking change in the 0.72 blog post? nushell/nushell.github.io#666

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

notes:breaking-changes This PR implies a change affecting users and has to be noted in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants