fix plugin detection in help commands#7088
Merged
fdncred merged 1 commit intonushell:mainfrom Nov 10, 2022
fdncred:fix_plugin_detection
Merged
fix plugin detection in help commands#7088fdncred merged 1 commit intonushell:mainfrom fdncred:fix_plugin_detection
fdncred merged 1 commit intonushell:mainfrom
fdncred:fix_plugin_detection
Conversation
This was referenced Nov 10, 2022
Contributor
|
LGTM! Thanks for fixing this @fdncred. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the problem where plugins are not detected properly in
help commands.Before - plugins were bucketed as "other"

After

Major Changes
If you're considering making any major change to nushell, before starting work on it, seek feedback from regular contributors and get approval for the idea from the core team either on Discord or GitHub issue.
Making sure we're all on board with the change saves everybody's time.
Thanks!
Tests + Formatting
Make sure you've done the following, if applicable:
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspace --features=extrato check that all tests passAfter Submitting