Skip to content

fix plugin detection in help commands#7088

Merged
fdncred merged 1 commit intonushell:mainfrom
fdncred:fix_plugin_detection
Nov 10, 2022
Merged

fix plugin detection in help commands#7088
fdncred merged 1 commit intonushell:mainfrom
fdncred:fix_plugin_detection

Conversation

@fdncred
Copy link
Contributor

@fdncred fdncred commented Nov 10, 2022

Description

Fixes the problem where plugins are not detected properly in help commands.

Before - plugins were bucketed as "other"
image

After
image

Major Changes

If you're considering making any major change to nushell, before starting work on it, seek feedback from regular contributors and get approval for the idea from the core team either on Discord or GitHub issue.
Making sure we're all on board with the change saves everybody's time.
Thanks!

Tests + Formatting

Make sure you've done the following, if applicable:

  • Add tests that cover your changes (either in the command examples, the crate/tests folder, or in the /tests folder)
    • Try to think about corner cases and various ways how your changes could break. Cover those in the tests

Make sure you've run and fixed any issues with these commands:

  • cargo fmt --all -- --check to check standard code formatting (cargo fmt --all applies these changes)
  • cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect to check that you're using the standard code style
  • cargo test --workspace --features=extra to check that all tests pass

After Submitting

  • Help us keep the docs up to date: If your PR affects the user experience of Nushell (adding/removing a command, changing an input/output type, etc.), make sure the changes are reflected in the documentation (https://github.com/nushell/nushell.github.io) after the PR is merged.

@dandavison
Copy link
Contributor

LGTM! Thanks for fixing this @fdncred.

@fdncred fdncred merged commit 3e56e81 into nushell:main Nov 10, 2022
@fdncred fdncred deleted the fix_plugin_detection branch November 10, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants