Support running batch files without typing their extension#6278
Merged
rgwood merged 2 commits intonushell:mainfrom Aug 9, 2022
Merged
Support running batch files without typing their extension#6278rgwood merged 2 commits intonushell:mainfrom
rgwood merged 2 commits intonushell:mainfrom
Conversation
Contributor
Author
|
Oops. Made a change that passes clippy on Windows but not Linux, will take a look. |
Contributor
Author
|
@fdncred as a fellow Windows Guy, does this sounds OK to you? |
Contributor
Author
|
fdncred confirmed on Discord that this looks OK. Merging now |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6270. It's once again possible to run a batch script named
foo.batorfoo.cmdby typingfoowithout the file extension.External command execution on Windows now works like this:
cmd.exebuiltin. If so, run it.which-rscan find an executable in PATH or the cwd.which-rshas logic to include executable file extensions in its search, so it will findfoo.cmdgiven justfoo. Run the found executable if its file name differs from the one we already attempted to run.Tests
Make sure you've done the following:
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspace --features=extrato check that all the tests pass