Suggest alternative when command not found#6256
Merged
rgwood merged 4 commits intonushell:mainfrom Aug 7, 2022
Merged
Conversation
Contributor
|
Like it! One small tweak you might want to try is making the error label be did you mean. On phone, but imagining the second image's label could be |
Contributor
Author
|
@jntrnr Good idea. Just to confirm that we're on the same page, something like this? |
Contributor
|
@rgwood - yeah exactly |
Contributor
Author
|
Done.
|
Contributor
|
really like this @rgwood! good work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #4996. When the user tries to run
foobut the command can't be found:foomatches any search terms for other commandsfoois similar to other command names (maybe it's a typo)Before
After
Before
After
Future Work
Once this is in place, we could probably delete the deprecated internal commands (as long as the right search terms exist for their replacements).
Tests
Make sure you've run and fixed any issues with these commands:
cargo fmt --all -- --checkto check standard code formatting (cargo fmt --allapplies these changes)cargo clippy --workspace --features=extra -- -D warnings -D clippy::unwrap_used -A clippy::needless_collectto check that you're using the standard code stylecargo test --workspace --features=extrato check that all the tests pass