Refactor arguments of path subcommands & Add path join subcommand#3123
Merged
sophiajt merged 2 commits intonushell:mainfrom Mar 4, 2021
Merged
Refactor arguments of path subcommands & Add path join subcommand#3123sophiajt merged 2 commits intonushell:mainfrom
sophiajt merged 2 commits intonushell:mainfrom
Conversation
DefaultArguments are no longer passed to each subcommand. Instead, each subcommand has its own Path<xxx>Arguments. This means that it is no longer necessary to edit every single path subcommand source file when changing the arguments struct.
Makes it easier to create new paths. It's just a wrapper around Rust's Path.join().
Contributor
|
Looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DefaultArgumentsto all path subcommands. Now each subcommand has its own set of arguments which all implement a common trait so they can be handled withoperateandhandle_valuefunctions.path joinsubcommand. Pretty straightorward, just appends a path to an input path.