Remove custom escaping for external args.#2095
Merged
sophiajt merged 1 commit intonushell:masterfrom Jul 2, 2020
thegedge:fix-bad-shell-escaping
Merged
Remove custom escaping for external args.#2095sophiajt merged 1 commit intonushell:masterfrom thegedge:fix-bad-shell-escaping
sophiajt merged 1 commit intonushell:masterfrom
thegedge:fix-bad-shell-escaping
Conversation
Our own custom escaping unfortunately is far too simple to cover all cases. Instead, the parser will now do no transforms on the args passed to an external command, letting the process spawning library deal with doing the appropriate escaping.
This was referenced Jul 3, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our own custom escaping unfortunately is far too simple to cover all cases. Instead, the parser will now do no transforms on the args passed to an external command, letting the process spawning library deal entirely with escaping.
Closes #1957
Still works for these two:
One case that doesn't work, but would likely require us to build custom parsing for external strings:
For that one I would have expected the output to be
test "ing"