Skip to content

fix(into_sqlite): pass a span along#17036

Merged
fdncred merged 1 commit intomainfrom
unknown repository
Nov 17, 2025
Merged

fix(into_sqlite): pass a span along#17036
fdncred merged 1 commit intomainfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Nov 17, 2025

Fixes #15410 and #16584 (or at least improves the situation)

not 100% sure if i chose the best span - if another one is more fitting and available i would be happy to change it.

old:

Error:
  × Failed to create table

new:

Error:
  × Failed to create table
   ╭─[entry #3:5:25]
 4 │   | each {|i| {"foo": "bar"} }
 5 │   | into sqlite -t test test.sqlite
   ·                         ─────┬─────
   ·                              ╰── table [test] already exists
 6 │ }
   ╰────

Release notes summary - What our users need to know

Improved into sqlite errors.

Tasks after submitting

  • cargo fmt --all -- --check
  • cargo clippy --workspace -- -D warnings -D clippy::unwrap_used
  • cargo test --workspace: fails (but shell::environment::env::path_is_a_list_in_repl seems unrelated to me)
    • cd crates/nu-command; cargo test

@fdncred
Copy link
Copy Markdown
Contributor

fdncred commented Nov 17, 2025

LGTM. Thanks

@fdncred fdncred merged commit 7b3b2ec into nushell:main Nov 17, 2025
16 checks passed
@github-actions github-actions bot added this to the v0.109.0 milestone Nov 17, 2025
@WindSoilder WindSoilder added the notes:fixes Include the release notes summary in the "Bug fixes" section label Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

notes:fixes Include the release notes summary in the "Bug fixes" section

Projects

None yet

Development

Successfully merging this pull request may close these issues.

into sqlite errors don't mark the into sqlite line

2 participants