Add assertion that DeprecationEntry flag do not have dashes#16475
Merged
sholderbach merged 2 commits intonushell:mainfrom Aug 19, 2025
Merged
Add assertion that DeprecationEntry flag do not have dashes#16475sholderbach merged 2 commits intonushell:mainfrom
sholderbach merged 2 commits intonushell:mainfrom
Conversation
sholderbach
reviewed
Aug 19, 2025
Ecorous
approved these changes
Aug 19, 2025
Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a
debug_assertwhen usingDeprecationType::Flagto ensure that the dashes aren't included as part of the flag name. This will hopefully catch something like the issue discovered in #16473 from occurring.Release notes summary - What our users need to know
N/A