Description

• Implemented FromValue for std::time::Duration.
  • It only converts positive Value::Duration values, negative ones raise ShellError::NeedsPositiveValue.
• Refactor job recv and watch commands to use this implementation rather than handling it ad-hoc.
  • Simplified watch's debounce & debounce-ms and factored it to a function. Should make removing debounce-ms after its deprecation period ends.
  • job recv previously used a numeric cast (i64 as u64) which would result in extremely long duration values rather than raising an error when negative duration arguments were given.

User-Facing Changes

Release notes summary

N/A

Changes in error messages:

• Providing the wrong type (bypassing parse time type checking):
  • Before

    Error: nu::shell::type_mismatch
    
      × Type mismatch.
       ╭─[entry #40:1:9]
     1 │ watch . --debounce (1 | $in) {|| }
       ·         ──────────┬─────────
       ·                   ╰── Debounce duration must be a duration
       ╰────
    

  • After

    Error: nu::shell::cant_convert
    
      × Can't convert to duration.
       ╭─[entry #2:1:9]
     1 │ watch . --debounce (1 | $in) {|| }
       ·         ──────────┬─────────
       ·                   ╰── can't convert int to duration
       ╰────
    

• Providing a negative duration value:
  • Before

    Error: nu::shell::type_mismatch
    
      × Type mismatch.
       ╭─[entry #41:1:9]
     1 │ watch . --debounce -100ms {|| }
       ·         ────────┬────────
       ·                 ╰── Debounce duration is invalid
       ╰────
    

  • After

    Error: nu::shell::needs_positive_value
    
      × Negative value passed when positive one is required
       ╭─[entry #4:1:9]
     1 │ watch . --debounce -100ms {|| }
       ·         ────────┬────────
       ·                 ╰── use a positive value
       ╰────