Fix panic in unit parsing with non-UTF8 code#16355
Merged
sholderbach merged 2 commits intonushell:mainfrom Aug 5, 2025
Merged
Conversation
Trying to parse non-UTF8 data as a value with unit (part of every literal parse) introduced a replacement character which shifted the span information so the indices where incorrect and triggered a panic. This has been resolved by removing a bad `String::from_utf8_lossy`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Trying to parse non-UTF8 data as a value with unit (part of every
literal parse) introduced a replacement character which shifted the span
information so the indices where incorrect and triggered
a panic.
This has been resolved by removing a bad
String::from_utf8_lossyUser-Facing Changes
One less possible panic
Tests + Formatting
Added a test with the original reproducer from fuzzing:
File with
0\xffBwhere the\xffrepresents the non utf-8 charFFrun as a script to trigger