Fix type checking for assignment operators#16107
Merged
ysthakur merged 3 commits intonushell:mainfrom Jul 4, 2025
Merged
Conversation
Member
Author
|
the PR title originally said "rework", but to be honest this is more of a fix than a rework since it aligns the behavior of |
ysthakur
approved these changes
Jul 4, 2025
Member
ysthakur
left a comment
There was a problem hiding this comment.
LGTM, this is a surprisingly simple change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Rel: #14429, #16079
Finishes up a TODO in the assignment type checking.
mut), type checking is now done usingtype_compatible(which is whatletuses)Before:
After:
+for+=) type checks successfully, and then checks if the assignment type checks successfully (also usingtype_compatible)Before:
After:
This is technically a breaking change if you relied on the old behavior (for example, there was a test that broke after this change because it relied on
/=improperly type checking)User-Facing Changes
$x = 123now uses the same type checking rules aslet x = 123ormut x = 123Tests + Formatting
Adds some tests for the examples given above
After Submitting
N/A