Allow enabling deprecated experimental options#16096
Merged
cptpiepmatz merged 1 commit intonushell:mainfrom Jul 2, 2025
Merged
Allow enabling deprecated experimental options#16096cptpiepmatz merged 1 commit intonushell:mainfrom
cptpiepmatz merged 1 commit intonushell:mainfrom
Conversation
sholderbach
approved these changes
Jul 2, 2025
Member
sholderbach
left a comment
There was a problem hiding this comment.
Sounds like a good fix for the desired behavior.
Thinking about this with the optin optout distinction....
currently the options are an identifier to switch to the alternate behavior. Whenever we want to migrate something from optin to optout we would have to invent new options and deprecate the old to introduce the inverse.
Or alternatively don't have this as a procedure at all. So either we introduce something with optin or sunset something with optout.
With the full flexibility we would need that the users always supply true/false with the identifier.
Member
Author
Nope, not passing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR changes the behavior of #16028 to allow enabling experimental options even if they are marked as deprecated.
Tests + Formatting
toolkit fmttoolkit clippytoolkit testtoolkit test stdlib