Skip to content

Allow enabling deprecated experimental options#16096

Merged
cptpiepmatz merged 1 commit intonushell:mainfrom
cptpiepmatz:allow-enabling-deprecated-experimental-options
Jul 2, 2025
Merged

Allow enabling deprecated experimental options#16096
cptpiepmatz merged 1 commit intonushell:mainfrom
cptpiepmatz:allow-enabling-deprecated-experimental-options

Conversation

@cptpiepmatz
Copy link
Copy Markdown
Member

Description

This PR changes the behavior of #16028 to allow enabling experimental options even if they are marked as deprecated.

Tests + Formatting

  • 🟢 toolkit fmt
  • 🟢 toolkit clippy
  • 🟢 toolkit test
  • 🟢 toolkit test stdlib

@cptpiepmatz cptpiepmatz requested a review from fdncred July 2, 2025 12:16
Copy link
Copy Markdown
Member

@sholderbach sholderbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good fix for the desired behavior.

Thinking about this with the optin optout distinction....

currently the options are an identifier to switch to the alternate behavior. Whenever we want to migrate something from optin to optout we would have to invent new options and deprecate the old to introduce the inverse.

Or alternatively don't have this as a procedure at all. So either we introduce something with optin or sunset something with optout.

With the full flexibility we would need that the users always supply true/false with the identifier.

Copy link
Copy Markdown
Contributor

@fdncred fdncred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It enables the features as expected. Thanks!
image

@cptpiepmatz
Copy link
Copy Markdown
Member Author

currently the options are an identifier to switch to the alternate behavior.

Nope, not passing true or false is a true

@cptpiepmatz cptpiepmatz merged commit 25a5e8d into nushell:main Jul 2, 2025
16 checks passed
@cptpiepmatz cptpiepmatz deleted the allow-enabling-deprecated-experimental-options branch July 2, 2025 14:46
@github-actions github-actions bot added this to the v0.106.0 milestone Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants