IR: rasing reasonable error when using subexpression with and operator#15623
Merged
WindSoilder merged 4 commits intonushell:mainfrom Apr 25, 2025
Merged
IR: rasing reasonable error when using subexpression with and operator#15623WindSoilder merged 4 commits intonushell:mainfrom
and operator#15623WindSoilder merged 4 commits intonushell:mainfrom
Conversation
and operator
sholderbach
reviewed
Apr 24, 2025
Member
sholderbach
left a comment
There was a problem hiding this comment.
Thanks for figuring out those failure cases!
Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #15510
I think it's introduced by #14653, which changes
and/ortomatchexpression.After looking into
compile_match, it's important to collect the value before matching this.This pr is going to apply the logic while compiling
and/oroperation.User-Facing Changes
The following will raise a reasonable error:
Tests + Formatting
Added 1 test.
After Submitting
Maybe need to update doc nushell/nushell.github.io#1876