Enhance polars plugin documentation#15250
Merged
ayax79 merged 3 commits intonushell:mainfrom Mar 5, 2025
Merged
Conversation
8897591 to
b304536
Compare
fdncred
reviewed
Mar 5, 2025
crates/nu_plugin_polars/src/dataframe/values/nu_expression/custom_value.rs
Show resolved
Hide resolved
b304536 to
2d0118b
Compare
Contributor
Author
|
@fdncred I can also close the two other PRs and only keep this one which includes all changes. |
Contributor
|
I've asked @ayax79 to take a look at your PRs. So, let's wait for him to help decide what is best. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR (based on #15249 and #15248 because it mentions them) adds extra documentation to the main polars command outlining the main datatypes that are used by the plugin. The lack of a description of the types involved in
polars xxxcommands was quite confusing to me when I started using the plugin and this is a first try improving it.I didn't find a better place but please let me know what you think.