Skip to content

Bump bytesize to fix into filesize#15088

Merged
sholderbach merged 1 commit intonushell:mainfrom
sholderbach:bytesize-fix
Feb 11, 2025
Merged

Bump bytesize to fix into filesize#15088
sholderbach merged 1 commit intonushell:mainfrom
sholderbach:bytesize-fix

Conversation

@sholderbach
Copy link
Member

Description

Closes #14866

Incorporates bytesize-rs/bytesize#59 with
bytesize version 1.3.1

User-Facing Changes

Now rejected strings

"1.3 1.3 kB" | into filesize
"1 420 kB" | into filesize

Tests + Formatting

Added test with invalid input that was silently ignored before

@sholderbach sholderbach added the notes:fixes Include the release notes summary in the "Bug fixes" section label Feb 11, 2025
Closes nushell#14866

Incorporates bytesize-rs/bytesize#59 with
bytesize version 1.3.1

Added test with invalid input that was silently ignored before
@sholderbach sholderbach merged commit 2a3d5a9 into nushell:main Feb 11, 2025
16 checks passed
@github-actions github-actions bot added this to the v0.103.0 milestone Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

notes:fixes Include the release notes summary in the "Bug fixes" section

Projects

None yet

Development

Successfully merging this pull request may close these issues.

into filesize silently ignores certain invalid inputs and strips anything after the first whitespace.

1 participant