Description

Changes the Value variant match arm of PipelineData::into_value to use the internal Value's span instead of the span passed in by the user. This aligns more closely with the ListStream and ByteStream match arms, which already use their internal span, and allows errors to provide better diagnostics since the span information doesn't get lost when into_value is called. At the suggestion of @cptpiepmatz, if the Value has Span::unknown for some reason, then we replace the Value's span with the passed in span.

Before:

{} | get foo bar
# => Error: nu::shell::column_not_found
# => 
# =>   × Cannot find column 'foo'
# =>    ╭─[entry #43:2:6]
# =>  2 │ {} | get foo bar
# =>    ·      ─┬─ ─┬─
# =>    ·       │   ╰── cannot find column 'foo'
# =>    ·       ╰── value originates here
# =>    ╰────

After:

{} | get foo bar
# => Error: nu::shell::column_not_found
# => 
# =>   × Cannot find column 'foo'
# =>    ╭─[entry #2:2:1]
# =>  2 │ {} | get foo bar
# =>    · ─┬       ─┬─
# =>    ·  │        ╰── cannot find column 'foo'
# =>    ·  ╰── value originates here
# =>    ╰────

User-Facing Changes

• Some errors may have more accurate info about where the value originates from

Tests + Formatting

• 🟢 toolkit fmt
• 🟢 toolkit clippy
• 🟢 toolkit test
• 🟢 toolkit test stdlib

After Submitting

N/A