Add doccomments to find functions in EngineState and StateWorkingSet#14750
Merged
WindSoilder merged 1 commit intonushell:mainfrom Jan 6, 2025
Merged
Add doccomments to find functions in EngineState and StateWorkingSet#14750WindSoilder merged 1 commit intonushell:mainfrom
find functions in EngineState and StateWorkingSet#14750WindSoilder merged 1 commit intonushell:mainfrom
Conversation
WindSoilder
approved these changes
Jan 6, 2025
Contributor
WindSoilder
left a comment
There was a problem hiding this comment.
Thanks! More documents always good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds some doccomments to some of the methods in
engine_state.rsandstate_working_set.rs. Also grouped together some of thefindmethods inengine_state.rs, but didn't do so instate_working_set.rssince they seem to already be grouped according to decl/overlay/module.Follow-up to #14490.
User-Facing Changes
None
Tests + Formatting
N/A
After Submitting
N/A