Conversation
|
Can we merge my PR instead, so I could get a contribution please 👉👈 |
That's why I was asking yesterday if you could get it down to just the error fixes. I would definitely have advocated for that to be merged. As it is, it still looks like it needs a lot of rollbacks. Like the indentation, changes to the plugin configs, As @fdncred said, we're running out of time. How quickly can you get that done? It's going to be a lot of work to merge this back on top of that at this point. |
I can do this now, sorry I probably missed what you requested |
|
@PerchunPak Thanks - If you can get that PR scaled back to just the critical fixes (mainly those that had colons instead of equal signs), along with any dangling space-removal, etc. I'd rebase and fix merge conflicts on top of that. You can add the versions as well. |
87d2244 to
8593d50
Compare
|
@NotTheDr01ds ping me when this is ready and i'll land it. |
|
@fdncred Thanks - Should be ready as soon as CI completes. |
Description
With great thanks to @fdncred and especially @PerchunPak (see #14601) for finding and fixing a number of issues that I pulled in here due to the filename changes and upcoming freeze.
This PR primarily fixes a poor wording choice in the new filenames and
configcommand options. The fact that these were calledsample_config.nu(etc.) and accessed viaconfig --samplecreated a great deal of confusion. These were never intended to be used as-is as config files, but rather as in-shell documentation.As such, I've renamed them:
sample_config.nubecomesdoc_config.nusample_env.nubecomesdoc_env.nuconfig nu --samplebecomesconfig nu --docconfig env --samplebecauseconfig env --docAlso the following:
doc_config.nuwith a few additional comment-fixes on top of @PerchunPak's changes.scaffold_*.nufiles to point people tohelp config/help nuso that, if things change in the future, it will become more difficult for the comments to be outdated.User-Facing Changes
Mostly doc.
config nuandconfig envchanges update new behavior previously added in 0.100.1Tests + Formatting
toolkit fmttoolkit clippytoolkit testtoolkit test stdlibAfter Submitting
bump-version.nu