Moves additional env vars out of default_env and updates some transient prompt vars#14579
Merged
fdncred merged 2 commits intonushell:mainfrom Dec 16, 2024
Merged
Conversation
Member
|
Should these environment variables only be added in interactive mode? I think for scripts these should not be added to avoid polluting the environment. |
0ec4b5c to
110989e
Compare
Contributor
Author
|
@IanManske Good point - I've moved them inside the interactive-check that |
Contributor
|
Thanks. I'm a little nervous about the TRANSIENT prompt changes but let's see how it goes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With
NU_LIB_DIRS,NU_PLUGIN_DIRS, andENV_CONVERSIONSnow moved out ofdefault_env.nu, we're down to just a few left. This moves all non-closurePROMPTvariables out as well (and into Rustmain(). It also:$env.TRANSIENT_PROMPT_COMMAND_RIGHTand$env.TRANSIENT_PROMPT_MULTILINE_INDICATOR#14565 and sets the defaultTRANSIENT_PROMPT_COMMAND_RIGHTandTRANSIENT_MULTILINE_INDICATORto an empty string so that they are removed for easier copying from the terminal.default_env.nu/default_config.nubefore userenv.nu/config.nu#14249 where I was overzealous in some of the variables that were importednu -n) after using Starship #12096$env.configand other variables are populated #13670User-Facing Changes
Transient prompt will now remove the right-prompt and multiline-indicator once a commandline has been entered.
Tests + Formatting
toolkit fmttoolkit clippytoolkit testtoolkit test stdlibAfter Submitting
Release notes addition