Skip to content

fix 64-bit hex number parsing#14571

Merged
fdncred merged 1 commit intonushell:mainfrom
fdncred:fix_64bit_parsing
Dec 13, 2024
Merged

fix 64-bit hex number parsing#14571
fdncred merged 1 commit intonushell:mainfrom
fdncred:fix_64bit_parsing

Conversation

@fdncred
Copy link
Copy Markdown
Contributor

@fdncred fdncred commented Dec 12, 2024

Description

Closes #14521

This PR tweaks the way 64-bit hex numbers are parsed.

Before

❯ 0xffffffffffffffef
Error: nu::shell::external_command

  × External command failed
   ╭─[entry #1:1:1]
 1 │ 0xffffffffffffffef
   · ─────────┬────────
   ·          ╰── Command `0xffffffffffffffef` not found
   ╰────
  help: `0xffffffffffffffef` is neither a Nushell built-in or a known external command

After

❯ 0xffffffffffffffef
-17

User-Facing Changes

Tests + Formatting

After Submitting

@fdncred fdncred mentioned this pull request Dec 12, 2024
Closed
@fdncred fdncred merged commit a7fa6d0 into nushell:main Dec 13, 2024
@fdncred fdncred deleted the fix_64bit_parsing branch December 13, 2024 13:00
@github-actions github-actions bot added this to the v0.101.0 milestone Dec 13, 2024
@fdncred fdncred added the notes:fixes Include the release notes summary in the "Bug fixes" section label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

notes:fixes Include the release notes summary in the "Bug fixes" section

Projects

None yet

Milestone

v0.101.0

Development

Successfully merging this pull request may close these issues.

64-bit hex numbers are not supported for use by the fmt command

1 participant

@fdncred