Make length only operate on supported input types#14475
Merged
sholderbach merged 2 commits intonushell:mainfrom Nov 29, 2024
Merged
Make length only operate on supported input types#14475sholderbach merged 2 commits intonushell:mainfrom
sholderbach merged 2 commits intonushell:mainfrom
Conversation
sholderbach
approved these changes
Nov 29, 2024
Member
sholderbach
left a comment
There was a problem hiding this comment.
Good call around Nothing and Empty! Thanks for spotting and fixing this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before this PR,
lengthdid not check its input type at run-time, so it would attempt to calculate a length for any input with indeterminate type (e.g.,echowhich has ananyoutput type). This PR makeslengthonly work on the types specifically supported in its input/output types (list/table, binary, and nothing), making the behavior the same at parse-time and at run-time.Fixes #14462
User-Facing Changes
Length will error if passed an unsupported type:
Before (only caught at parse-time):
After (caught at parse-time and run-time):
Tests + Formatting
toolkit fmttoolkit clippytoolkit testtoolkit test stdlibAfter Submitting