Allow inherited environment variables#14467
Merged
fdncred merged 1 commit intonushell:mainfrom Nov 28, 2024
Merged
Conversation
Contributor
|
Agreed. This config stuff is getting better and better. Thanks! |
This was referenced Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Due to #14249 loading
default_env.nubefore the user'senv.nu, variables that were defined there were overriding:NU_LIB_PATHwhen set using--include-path.This change checks to see if a variable already exists, uses its value if so, and sets the default value otherwise.
Note:
ENV_CONVERSIONSis still "forced" to a default value regardless, as it needs to run reliably. There's probably not much reason to inherit it, but I'm open to the idea if there's a use-case.User-Facing Changes
default_env.nualways overrode those that were inherited from the parent process or set internallyTests + Formatting
toolkit fmttoolkit clippytoolkit testtoolkit test stdlibAfter Submitting
Will try to find a good place to mention this behavior in the Config chapter updates