Merged
Conversation
Contributor
|
Why is the other test now ignored? |
Contributor
Author
|
Oh... It's ignored locally, I forget to delete it. |
Member
|
Thanks, great to see the deduplication! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The test is failed when updating miette from 7.2 to 7.3. After looking into the test, I think it's ok to adjust test.
User-Facing Changes
For the given custom command:
Before
After
As we can see, the message
oh no!is output in a new line, and there is one less trailing line. I have makes some testing, and it seems that it only happened onerror makecommand.Tests + Formatting
Changed 1 test
After Submitting
NaN