Skip to content

update miette to 7.3#14454

Merged
sholderbach merged 2 commits intonushell:mainfrom
WindSoilder:miette_ver
Nov 27, 2024
Merged

update miette to 7.3#14454
sholderbach merged 2 commits intonushell:mainfrom
WindSoilder:miette_ver

Conversation

@WindSoilder
Copy link
Copy Markdown
Contributor

Description

The test is failed when updating miette from 7.2 to 7.3. After looking into the test, I think it's ok to adjust test.

User-Facing Changes

For the given custom command:

def force_error [ x: any ] {
    error make {
        msg: "oh no!"
        label: {
            text: "here's the error"
            span: (metadata $x).span
        }
    }
}

Before

> force_error "My error"
Error:   × oh no!
   ╭─[entry #8:1:13]
 1 │ force_error "My error"
   ·             ─────┬────
   ·                  ╰── here's the error
   ╰────

After

> force_error "My error"
Error:
  × oh no!
   ╭─[entry #9:1:13]
 1 │ force_error "My error"
   ·             ─────┬────
   ·                  ╰── here's the error
   ╰────

As we can see, the message oh no! is output in a new line, and there is one less trailing line. I have makes some testing, and it seems that it only happened on error make command.

Tests + Formatting

Changed 1 test

After Submitting

NaN

@fdncred
Copy link
Copy Markdown
Contributor

fdncred commented Nov 27, 2024

Why is the other test now ignored?

@WindSoilder
Copy link
Copy Markdown
Contributor Author

Oh... It's ignored locally, I forget to delete it.

@sholderbach
Copy link
Copy Markdown
Member

Thanks, great to see the deduplication!

@sholderbach sholderbach merged commit a13a024 into nushell:main Nov 27, 2024
@github-actions github-actions bot added this to the v0.101.0 milestone Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants