Always populate config record during startup#14435
Merged
WindSoilder merged 3 commits intonushell:mainfrom Nov 27, 2024
Merged
Conversation
IanManske
approved these changes
Nov 26, 2024
Member
IanManske
left a comment
There was a problem hiding this comment.
Nice! Thanks for all the tests as well.
Contributor
|
Actually I'm a little confused. |
Contributor
Author
It represents all of the internal defaults from |
WindSoilder
approved these changes
Nov 27, 2024
Contributor
WindSoilder
left a comment
There was a problem hiding this comment.
Thanks! I get the idea behind it. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As a bit of a follow-on to #13802 and #14249, this (pretty much a "one-line" change) really does always populate the
$env.configrecord with thenu-protocol::configdefaults during startup. This means that an$env.configrecord is value (with defaults) even during:nu -nto suppress loading of config filesnu -c <commandstring>nu <script>User-Facing Changes
There should be no case in which there isn't a valid
$env.config.Before:
After:
Startup time impact is negligible (17.072µs from
perf!on my system) - Seems well worth it.Tests + Formatting
Added tests for several
-n -ccases.toolkit fmttoolkit clippytoolkit testtoolkit test stdlibAfter Submitting
Config chapter update still in progress.