make std help more user friendly#14347
Merged
WindSoilder merged 1 commit intonushell:mainfrom Nov 27, 2024
Merged
Conversation
Contributor
This was my main concern when I looked at it initially. I wasn't sure it was worthwhile enough that someone would tackle it, but I'm glad you did! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #13159
After the change,
std helpwill no-longer print out "double error" messages.Actually I think it's tricky to make it right. To make
help <cmd>keeps paging feature from fallbackmancommand. I have to splitcommandsintoscope-commandsandexternal-commands.If we don't split it, simply call
let commands = (try { commands $target_item --find $find })inhelp mainwill cause us to lost paging feature, which is not we want.A comment from original issue:
Actually I think it's a beautiful feature of
std help, so I want to keep it here.User-Facing Changes
Before
After
Tests + Formatting
Actually it's a little hard to add test because it required user input (especially for fallback
mancommand)