Fix deleted lowercase in keybinding parsing#14081
Merged
IanManske merged 2 commits intonushell:mainfrom Oct 13, 2024
Merged
Conversation
sholderbach
approved these changes
Oct 13, 2024
Member
sholderbach
left a comment
There was a problem hiding this comment.
Thanks spotting and fixing that immediately!
Is there something wrong with the span logic, as the error message seem by @Yethal pointed into the void?
Member
Author
|
I was wondering that as well. I assume it's related to the assignment code. The config update only has access to the value span. I can look into it later today. |
Contributor
|
Should we go ahead and land this one? or should we wait for Ian's research? |
Member
Author
|
I can do a follow-up PR, so I'll merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds back the
to_ascii_lowercasedeleted in #13802. Also fixes the error messages having the lowercased value instead of the original value.