Replace IncorrectValue with InvalidValue#14079
Closed
IanManske wants to merge 2 commits intonushell:mainfrom
Closed
Replace IncorrectValue with InvalidValue#14079IanManske wants to merge 2 commits intonushell:mainfrom
IncorrectValue with InvalidValue#14079IanManske wants to merge 2 commits intonushell:mainfrom
Conversation
Member
|
@IanManske I locally started fixing those tests (and stumbled accross small issues to fix in the impl see #14147) |
Member
|
I think this is really stale now, so closing it for now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow up to #13802. This PR replaces usages of
ShellError::IncorrectValuewithInvalidValueor other appropriate error cases.User-Facing Changes
None, some errors messages may be different.