Add parse error for external commands used in assignment without caret#13585
Merged
sholderbach merged 2 commits intonushell:mainfrom Aug 12, 2024
Merged
Conversation
Member
|
Perhaps you could use the |
Contributor
Author
|
Yeah, I guess I might have to. At some point I should really try to unify that infrastructure |
Contributor
Author
|
So fast! Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As per our Wednesday meeting, this adds a parse error when something that would be parsed as an external call is present at the top level, unless the head of the external call begins with a caret (to make it explicit).
I tried to make the error quite descriptive about what should be done.
User-Facing Changes
These now cause a parse error:
These would have been interpreted as strings before this version, but now they'd be interpreted as external calls. This behavior is consistent with
let/mut(which is unaffected by this change).Here is an example of the error:
Tests + Formatting
Tests added to cover the change. Note made about it being temporary.