don't allow break/continue in each and items command#13398
Merged
devyn merged 5 commits intonushell:mainfrom Jul 19, 2024
Merged
don't allow break/continue in each and items command#13398devyn merged 5 commits intonushell:mainfrom
each and items command#13398devyn merged 5 commits intonushell:mainfrom
Conversation
devyn
reviewed
Jul 17, 2024
Contributor
devyn
left a comment
There was a problem hiding this comment.
This is good, the IR generation is already a bit weird when there's no loop target found, we have to generate a real call to continue/break, so this frees us up from absolutely having to do that
each and items commandeach and items command
Contributor
|
Okay, let's do it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #11451
User-Facing Changes
Before
After
Tests + Formatting
Removes some tests.