generate: switch the position of <initial> and <closure>, so the closure can have default parameters #13393
Merged
devyn merged 12 commits intonushell:mainfrom Jul 19, 2024
Merged
Conversation
sholderbach
reviewed
Jul 17, 2024
Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com>
Contributor
|
Sure, this sounds like an easy enough thing that typechecking will be able to help with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close: #12083
Close: #12084
User-Facing Changes
It's a breaking change because we have switched the position of
<initial>and<closure>, after the change, initial value will be optional. So it's possible to do something like this:It will also raise error if user don't give initial value, and the closure don't have default parameter.
Tests + Formatting
Added some test cases.