Merged
Conversation
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recommend holding until after #13125 is fully digested and possibly until 0.96.
Description
Fixes one of the issues described in #13125
The
dosignature included aSyntaxShape:Anyas one of the possible first-positional types. This is incorrect.doonly takes a closure as a positional. This had the result of:Moving what should have been a parser error to evaluation-time
Before
After
Masking a bad test in
std assertThis is a bit convoluted, but
std asserttests included testingassert errorto make sure it:The good-code test was broken, and was essentially bad-code (really bad-code) that wasn't getting caught due to the bad signature.
Fixing this resulted in parse time failures on every call to
test_asserts(not something that particular test was designed to handle.This PR also fixes the test case to properly evaluate
std assert erroragainst a good code path.User-Facing Changes
Tests + Formatting
toolkit fmttoolkit clippytoolkit testtoolkit test stdlibAfter Submitting
N/A