Skip to content

Do example#13190

Merged
fdncred merged 2 commits intonushell:mainfrom
NotTheDr01ds:do-example
Jun 20, 2024
Merged

Do example#13190
fdncred merged 2 commits intonushell:mainfrom
NotTheDr01ds:do-example

Conversation

@NotTheDr01ds
Copy link
Copy Markdown
Contributor

@NotTheDr01ds NotTheDr01ds commented Jun 20, 2024

Description

#12056 added support for default and type-checked arguments in do closures.

This PR adds examples for those features. It also:

  • Fixes the TODO (a closure parameter that wasn't being used) that was preventing a result from being added
  • Removes extraneous commas from the descriptions
  • Adds an example demonstrating multiple positional closure arguments

User-Facing Changes

Help examples only

Tests + Formatting

  • 🟢 toolkit fmt
  • 🟢 toolkit clippy
  • 🟢 toolkit test
  • 🟢 toolkit test stdlib

After Submitting

@fdncred
Copy link
Copy Markdown
Contributor

fdncred commented Jun 20, 2024

Looks good. Thanks!

@fdncred fdncred merged commit 4c82a74 into nushell:main Jun 20, 2024
@hustcer hustcer added this to the v0.95.0 milestone Jun 21, 2024
@fdncred fdncred added the deprecated:pr-commands (deprecated: too vague) This PR changes our commands in some way label Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecated:pr-commands (deprecated: too vague) This PR changes our commands in some way

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants