Technically a breaking change.

Are we ready to land this @WindSoilder?

I am not sure if the logic you added @WindSoilder is specific to the case but for your example I think we could find a more specific error message that there is additional text after the closing delimiter. I think otherwise the unclosed delimiter message is a bit confusing if you encounter a longer string.

@sholderbach Do you have any good suggestions?
I have tried how python and rust report these error, they gives me something like this:

Python

> "asdfa"asdfa
  Cell In[1], line 1
    "asdfa"asdfa
           ^
SyntaxError: invalid syntax

Rust

error: suffixes on string literals are invalid
    --> crates/nu-parser/src/parser.rs:2836:17
     |
2836 |         let x = "asdfaf"asdfa;
     |                 ^^^^^^^^^^^^^ invalid suffix `asdfa`

It seems that they just say something is invalid

I think we can slightly improve on the Rust message with "invalid characters after closing delimiter" but only if that is emitted if we previously rule out the "missing closing delimiter"

Thanks! Here are the new error messages:

❯ "asdfasdf"asdfasdf
Error: nu::parser::extra_token_after_closing_delimiter

  × Invaild characters after closing delimiter
   ╭─[entry #1:1:11]
 1 │ "asdfasdf"asdfasdf
   ·           ────┬───
   ·               ╰── invalid characters
   ╰────
  help: Try removing them.
❯ 'asdfasd'adsfadf
Error: nu::parser::extra_token_after_closing_delimiter

  × Invaild characters after closing delimiter
   ╭─[entry #2:1:10]
 1 │ 'asdfasd'adsfadf
   ·          ───┬───
   ·             ╰── invalid characters
   ╰────
  help: Try removing them.

Are you ready to land this one @WindSoilder?

Yeah, sure. I think it's ok for now