fix: coredump without any messages#13034
Merged
fdncred merged 2 commits intonushell:mainfrom Jun 7, 2024
Merged
Conversation
Contributor
Author
|
@fdncred can you help review it? Thanks |
fdncred
reviewed
Jun 3, 2024
Contributor
|
I think it's probably good after my one requested change. |
Co-authored-by: Darren Schroeder <343840+fdncred@users.noreply.github.com>
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I want to fix the issue which is induced by the fix for Error in
completeexit_code field instead of numerical exit code #12369. after this pr. This pr induced a new error for unix system, in order to show coredump messagesUser-Facing Changes
after fix for 12874, coredump message is messing, so I want to fix it
Tests + Formatting
After Submitting