Skip to content

Remove list support in with-env#12939

Merged
WindSoilder merged 1 commit intonushell:mainfrom
IanManske:with-env-removal
May 23, 2024
Merged

Remove list support in with-env#12939
WindSoilder merged 1 commit intonushell:mainfrom
IanManske:with-env-removal

Conversation

@IanManske
Copy link
Copy Markdown
Member

@IanManske IanManske commented May 23, 2024

Description

Following from #12523, this PR removes support for lists of environments variables in the with-env command. Rather, only records will be supported now.

After Submitting

Update examples using the list form in the docs and book.

@IanManske IanManske added notes:breaking-changes This PR implies a change affecting users and has to be noted in the release notes category:removal-after-deprecation The component has already been sunset with `deprecation` and is now up for final removal deprecated:pr-commands (deprecated: too vague) This PR changes our commands in some way labels May 23, 2024
Copy link
Copy Markdown
Contributor

@WindSoilder WindSoilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me

@WindSoilder WindSoilder merged commit 2612a16 into nushell:main May 23, 2024
@hustcer hustcer added this to the v0.94.0 milestone May 23, 2024
@IanManske IanManske deleted the with-env-removal branch June 23, 2024 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:removal-after-deprecation The component has already been sunset with `deprecation` and is now up for final removal deprecated:pr-commands (deprecated: too vague) This PR changes our commands in some way notes:breaking-changes This PR implies a change affecting users and has to be noted in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants