Skip to content

Fixing NuLazyFrame/NuDataFrame conversion issues#12538

Merged
fdncred merged 1 commit intonushell:mainfrom
ayax79:df_lazy_conversion
Apr 16, 2024
Merged

Fixing NuLazyFrame/NuDataFrame conversion issues#12538
fdncred merged 1 commit intonushell:mainfrom
ayax79:df_lazy_conversion

Conversation

@ayax79
Copy link
Copy Markdown
Contributor

@ayax79 ayax79 commented Apr 16, 2024

Description

@maxim-uvarov brought up another case where converting back and forth between eager and lazy dataframes was not working correctly:

> [[a b]; [6 2] [1 4] [4 1]] | polars into-lazy | polars append -c ([[a b]; [6 2] [1 4] [4 1]] | polars into-df)
Error: nu::shell::cant_convert

  × Can't convert to NuDataFrame.
   ╭─[entry #1:1:49]
 1 │ [[a b]; [6 2] [1 4] [4 1]] | polars into-lazy | polars append -c ([[a b]; [6 2] [1 4] [4 1]] | polars into-df)
   ·                                                 ──────┬──────
   ·                                                       ╰── can't convert NuLazyFrameCustomValue to NuDataFrame
   ╰────

This pull request fixes this case and glaringly obvious similar cases I could find.

@fdncred fdncred merged commit a7a5ec3 into nushell:main Apr 16, 2024
@fdncred
Copy link
Copy Markdown
Contributor

fdncred commented Apr 16, 2024

Thanks. Appreciate all your work here!

@ayax79 ayax79 deleted the df_lazy_conversion branch April 16, 2024 22:18
@hustcer hustcer added this to the v0.93.0 milestone Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants