Skip to content

Two consecutive calls to into-lazy should not fail#12505

Merged
fdncred merged 1 commit intonushell:mainfrom
ayax79:polars_lazy_lazy
Apr 13, 2024
Merged

Two consecutive calls to into-lazy should not fail#12505
fdncred merged 1 commit intonushell:mainfrom
ayax79:polars_lazy_lazy

Conversation

@ayax79
Copy link
Copy Markdown
Contributor

@ayax79 ayax79 commented Apr 13, 2024

Description

From @maxim-uvarov's post.

When calling to-lazy back to back in a pipeline, an error should not occur:

> [[a b]; [6 2] [1 4] [4 1]] | polars into-lazy | polars into-lazy
Error: nu::shell::cant_convert

  × Can't convert to NuDataFrame.
   ╭─[entry #1:1:30]
 1 │ [[a b]; [6 2] [1 4] [4 1]] | polars into-lazy | polars into-lazy
   ·                              ────────┬───────
   ·                                      ╰── can't convert NuLazyFrameCustomValue to NuDataFrame
   ╰────

This pull request ensures that custom value's of NuLazyFrameCustomValue are properly converted when passed in.

@fdncred fdncred merged commit 10a9a17 into nushell:main Apr 13, 2024
@fdncred
Copy link
Copy Markdown
Contributor

fdncred commented Apr 13, 2024

thanks

@ayax79 ayax79 deleted the polars_lazy_lazy branch April 13, 2024 18:01
@fdncred fdncred added the A:plugin-polars Work related to the polars dataframe implementation label Apr 13, 2024
@hustcer hustcer added this to the v0.93.0 milestone Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A:plugin-polars Work related to the polars dataframe implementation

Projects

None yet

Milestone

v0.93.0

Development

Successfully merging this pull request may close these issues.

3 participants

@ayax79 @fdncred @hustcer