Skip to content

Linear Regression #11542

Closed
TrifanBogdan24 wants to merge 2 commits intonushell:mainfrom
TrifanBogdan24:main
Closed

Linear Regression #11542
TrifanBogdan24 wants to merge 2 commits intonushell:mainfrom
TrifanBogdan24:main

Conversation

@TrifanBogdan24
Copy link
Copy Markdown

Solved issue: #11392
Added Linear Regression Algorithm that will return the line that goes the best through a set of points in @d.
My method will either return d : y = a * x + b or d : x = a.

Please checkout the README.md at the location crates/nu-command/src/math/nushell-liniar-regression/README.md, where I explained my method.

https://github.com/TrifanBogdan24/nushell-linear-regression.git

Copy link
Copy Markdown
Contributor

@fdncred fdncred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. We appreciate you trying to make nushell better.

I'm not sure how popular linear regression calculation is but I think we'd want to put this in the extra crate with the other not frequently used match commands.

Also, linear is spelled liniar in some places.

We probably shouldn't have a path that uses nushell in the name like nushell-liniar-regression since it's a crate in nushell there's no need for nushell.

I wonder if this should be in a plugin rather than in the extra crate too. I'll let others chime in on that.

@amtoine
Copy link
Copy Markdown
Member

amtoine commented Jan 16, 2024

the last status in #11392 was to implement a plugin first and see if people use it.
not sure having that built-into Nushell makes that much sense as a first step

@fdncred fdncred marked this pull request as draft January 20, 2024 14:19
@fdncred
Copy link
Copy Markdown
Contributor

fdncred commented Jan 20, 2024

Converting to a draft until we find a way forward. I'd support a plugin and also put it in awesome-nu as well.

@alexandruradovici
Copy link
Copy Markdown

@TrifanBogdan24 can you try converting this into a plugin?

@fdncred
Copy link
Copy Markdown
Contributor

fdncred commented Feb 26, 2024

If someone wants to take this code and put in a plugin, have at it. I'll list it on awesome-nu if you ping me with it. Closing this for now.

@fdncred fdncred closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants