Fix: #7760 Use active overlays config value#10613
Closed
jakeswenson wants to merge 4 commits intonushell:mainfrom
Closed
Fix: #7760 Use active overlays config value#10613jakeswenson wants to merge 4 commits intonushell:mainfrom
config value#10613jakeswenson wants to merge 4 commits intonushell:mainfrom
Conversation
Author
|
Moving this PR back to draft because when testing #10592 with this fix I noticed changes with |
Contributor
|
Thanks for proposing the PR. I think it's too old and still a draft PR. I'm going to close it. If you think the change is still necessary, feel free to resolve the conflict and open a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #7760 by modifying
EngineState::merge_envto update the engine stateconfigreference after merging the environment.User-Facing Changes
Tests + Formatting
I've added tests that fail without my fix, and succeed after. However getting tests to work involved adding substantial changes to the
nu_repltest bin to:--config...)After Submitting
N/A - just a bug fix
fixes #7760